Skip to content

fix(overview): keep the panel non-opaque so closing never flashes - #296

Closed
qeude wants to merge 1 commit into
mainfrom
fix/overview-close-flash
Closed

qeude wants to merge 1 commit into
mainfrom
fix/overview-close-flash

Conversation

@qeude

@qeude qeude commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Summary

Closing the Overview opened from a native full-screen window could blink: for a frame or a few, the full-screen window showed through the panel, then the closing zoom resumed over the wallpaper.

 OverviewPanel.uncoverChrome (end of the opening zoom)
-  window.isOpaque = hasWallpaper; backgroundColor = black
+  window stays non-opaque (its layers still paint the black backing and wallpaper)

The closing zoom installs the menu bar and Dock mask and needs a non-opaque window. Flipping isOpaque back to false on a window already on screen let one frame through. From the desktop that frame shows the desktop, so nobody saw it.

Evidence

In the defi-e2e VM: real daemon, Accessibility and Screen Recording granted, TextEdit in native full screen. Each trial opens the Overview from the full-screen Space and closes it while screencapture -v records. A flash is a frame of the window between frames of the Overview, found by measuring the luma of a screen corner.

  • Probe: the panel (layer 25) stays on screen through the whole close; the active Space and frontmost app never change. So this is not a Space switch or an activation.
  • Before (main and fix(fullscreen): give native full-screen columns the viewport width #295's base): flashes in 3 of 7 readable recordings (3 more recordings failed when screencapture hung).
  • After: 0 of 8.
  • make verify passes.

Not covered: two displays; Computer Use on the installed build; a cost measurement of the non-opaque window (it was already non-opaque while chrome is uncovered and without a captured wallpaper).

Merge Danger

Door: two-way

Blast Radius: Overview panel compositing

The open panel is now composited as non-opaque. Its content is still opaque, so nothing should show through.

Note

Remove opacity changes from OverviewPanel.uncoverChrome to fix close flash

uncoverChrome in OverviewPanel.swift no longer checks for a captured desktop or toggles the panel's opacity and background color. It still clears the chrome mask and commits the Core Animation transaction. The window now stays non-opaque, so closing the panel no longer flashes.

Macroscope summarized 690609d.

Turning the panel window opaque after the opening zoom and back at closing,
while it is on screen, let one frame show the windows beneath. Over a native
full-screen window that frame is the window itself, so the Overview blinked.
@github-actions github-actions Bot added the macroscope-review Request a Macroscope review label Nov 15, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 15, 2026

Copy link
Copy Markdown

Approvability

Verdict: Approved at 690609d

Macroscope's review found this PR approvable — This keeps Overview non-opaque after its opening transition to prevent a closing flash, while preserving its backing layers. The change is confined to local rendering, with recorded full-screen trials supporting the intended improvement.

Notes:

  • Macroscope's correctness review did not run, so approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

qeude added a commit that referenced this pull request Nov 15, 2026
Turning the panel window opaque at the end of the opening zoom and back at
closing, while it is on screen, let a frame show the windows beneath, and cost
one or two frames at the zoom's landing on a 120 Hz display (8 of 12 opens).
The window stays non-opaque; its layers still paint the backing and wallpaper.

Same change as #296.
qeude added a commit that referenced this pull request Nov 16, 2026
Turning the panel window opaque at the end of the opening zoom and back at
closing, while it is on screen, let a frame show the windows beneath, and cost
one or two frames at the zoom's landing on a 120 Hz display (8 of 12 opens).
The window stays non-opaque; its layers still paint the backing and wallpaper.

Same change as #296.
qeude added a commit that referenced this pull request Nov 16, 2026
…295)

* fix(overview): keep full-screen cards at the picture's aspect ratio

A native full-screen window's card has the column width, while its picture
is a whole display. The opening zoom scaled that picture non-uniformly into
the card and left it there, so the preview looked squeezed.

Full-screen windows no longer zoom from the desktop, which they are not on,
and their card draws the picture aspect-fit, centred over the card's
background, with the title above and the Full Screen label below.

Closes #289

* fix(fullscreen): give a native full-screen column the viewport width

Like Niri, a full-screen window spans the display, so its column now spans
the viewport in the strip and in the Overview, while the placement keeps the
width it returns to on exit. The Overview card then has the picture's shape
and uses the same aspect-fill as every other card, so the letterbox is gone.
A column that still holds visible stacked windows keeps its own width.

Refs #289

* fix(overview): zoom a native full-screen window into its card again

Its card now spans the viewport, so the picture zooms in without stretching.
Skipping it left no visible anchor when the Overview opened from the full-screen
Space, and the opening fell back to a fade.

* fix(overview): crop a zoomed picture like its card instead of stretching it

A full-screen window's card is shaped unlike the display, so scaling the
picture to it squeezed the content, and the zoom layer stays over the card.
The zoom now animates the crop with the size and ends on the card's aspect fill.

* fix(overview): hide the Overview before macOS slides to another Space

Choosing a window on another Space, such as a desktop window from a native
full-screen Space, made macOS slide while the Overview stayed open until the
focus committed: it vanished on one side and showed again on the destination
for about a second. The panels now hide at once and the close skips the zoom.

* fix(overview): fade the Overview out at 120 Hz before a Space slide

Hiding the panels at once cut the transition to zero frames. The panel now
fades with Core Animation at the Overview's 120 Hz preference, like its other
transitions, then orders out.

* perf(overview): render the glass during the still first pose of the zoom

The glass and its cards stayed at alpha 0 until the zoom moved, so its first
moving frame paid for the 5K glass, every card picture and their textures at
once: 75-225 ms on a 120 Hz display for a full-screen or maximized window.
At alpha 0.002 they render while the first pose, which matches the desktop,
is on screen.

* fix(overview): keep the panel non-opaque so closing never flashes

Turning the panel window opaque at the end of the opening zoom and back at
closing, while it is on screen, let a frame show the windows beneath, and cost
one or two frames at the zoom's landing on a 120 Hz display (8 of 12 opens).
The window stays non-opaque; its layers still paint the backing and wallpaper.

Same change as #296.

* fix(fullscreen): leave the desk untouched across a native full-screen round trip

Entering full screen, macOS slides the desk away while Defi still moved its
windows; leaving, the app put its window back late and Defi slid the strip
to wherever the scroll had drifted. The desk now stays as the user left it:
windows behind a full-screen Space are not written, the strip returns to its
scroll from before the entry, the overlay holds the desk until the window is
back, and a black capture taken from a full-screen Space no longer replaces
the wallpaper.

* fix(fullscreen): keep the saved scroll in viewport units across a display resize
@qeude

qeude commented Nov 16, 2026

Copy link
Copy Markdown
Owner Author

Shipped in #295 (173891d), which carries the same change to OverviewPanel.swift.

@qeude qeude closed this Nov 16, 2026
@qeude
qeude deleted the fix/overview-close-flash branch November 16, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Request a Macroscope review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant